Open
Conversation
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
github-actions
Bot
added
sql
logical-expr
core
physical-expr
optimizer
proto
substrait
labels
avantgardnerio
changed the title
avantgardnerio
approved these changes
Oct 14, 2025
avantgardnerio
left a comment
avantgardnerio
left a comment
There was a problem hiding this comment.
This looks like just a cherry-pick, so ✅ . The check that is failing does not prevent merge.
If you can keep the upstream PR # in your PR title than it makes this easier to manage when we upgrade. (I added it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for: