Skip to content

Conversation

@midsbie
Copy link
Contributor

@midsbie midsbie commented Sep 15, 2025

The function s-equals-p from the s library was referenced in the code but the dependency had not been declared.

Since the referenced function is nothing but a wrapper around string-equal (see below), this PR refactors the code to call string-equal directly and drop the dependency altogether.

  (defun s-equals? (s1 s2)
    "Is S1 equal to S2?

  This is a simple wrapper around the built-in `string-equal'."
    (declare (pure t) (side-effect-free t))
    (string-equal s1 s2))

The function `s-equals-p` from the s library was referenced in the code but the dependency had not
been declared.

Since the referenced function is nothing but a wrapper around `string-equal` (see below), this
commit refactors the code to call `string-equal` directly and drop the dependency altogether.

  (defun s-equals? (s1 s2)
    "Is S1 equal to S2?

  This is a simple wrapper around the built-in `string-equal'."
    (declare (pure t) (side-effect-free t))
    (string-equal s1 s2))
@midsbie
Copy link
Contributor Author

midsbie commented Sep 15, 2025

Is there any specific reason why the files copilot-autoloads.el and copilot-pkg.el haven't been added as git ignore clauses? Can add, if no reason; just let me know.

@bbatsov
Copy link
Collaborator

bbatsov commented Sep 16, 2025

Is there any specific reason why the files copilot-autoloads.el and copilot-pkg.el haven't been added as git ignore clauses? Can add, if no reason; just let me know.

Just an oversight.

@bbatsov bbatsov merged commit c42c18e into copilot-emacs:main Sep 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants