Skip to content

fix: incident suggestions #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexsegura merged 29 commits into from
Dec 29, 2025
Merged

fix: incident suggestions #5153

alexsegura merged 29 commits into from
Dec 29, 2025

Conversation

@vladimir-8
Copy link
Contributor

@vladimir-8 vladimir-8 commented Dec 3, 2025 •
edited
Loading

Various changes required to enable reporting an Incident with suggestions from the mobile apps: coopcycle/coopcycle-app#2061

  • allow Courier read-only access to Stores
  • allow Courier read-only access to Stores' TimeSlots
  • allow Courier read-only access to Stores' TimeSlot choices
  • allow Courier read-only access to Stores' Packages
  • allow Courier read-only access to Stores' pricing rules
  • added: api to get delivery form data (to edit delivery or report incorrect data via an incident)
  • minor fixes on how suggestions are displayed on the Incident page

@vladimir-8
fix: check a product variant name while comparing
70727f8
@vladimir-8
Merge branch 'master' into fix/incident-suggestions
e6632ed
@vladimir-8
add 'store' uri to tasks (when applicable)
d80234e
@vladimir-8
apply format
e094fdd
@vladimir-8
allow Courier read-only access to Stores
8a761dd
@vladimir-8
allow Courier read-only access to Stores' TimeSlots
ba648e3
@vladimir-8
allow Courier read-only access to Stores' TimeSlot choices
c77d8f3
@vladimir-8
allow Courier read-only access to Stores' Packages
60906a9
@vladimir-8
allow Courier read-only access to Stores' pricing rules
c8f47a9
@vladimir-8
added: api to get delivery form data (to edit delivery or report inco…
6a59493 
…rrect data via an incident
@vladimir-8
return 404 for standalone tasks
b0ded0a
@vladimir-8
extract PriceChangeSuggestion component
91de28b
@vladimir-8
display suggested changes
e389093
@vladimir-8
rename: INCIDENTS_ERROR_LOADING_SUGGESTED_PRICE_CHANGE key
f6f1f08
@vladimir-8
display price before and after only if there is a change
f9b0ba4
@vladimir-8
use 'undefined' consistently
a3a4f9c
@vladimir-8
suggest price changes only on local commerce and last mile orders
74c8f9b
@vladimir-8
improve can't calculate a price error display
61ed902
@vladimir-8
hide suggestion content by default
32c3fff
@vladimir-8
Merge branch 'master' into fix/incident-suggestions
53022cf
@vladimir-8
Merge branch 'task/incident-fixtures' into fix/incident-suggestions
ff1642f
@vladimir-8
fix: lint warning
a7a400e
@vladimir-8
don't set 'store' on a metadata if it's null
94d4ad8
@vladimir-8
add(api test); '/tasks/{id}/delivery_form_data' endpoint
68d6898
@vladimir-8
add: localisation
e75e8e4
@vladimir-8
handle a case when metadata is an object
fbb44e6
@vladimir-8
fix: reset array indexes after filtering
6bca313
@vladimir-8
Merge branch 'master' into fix/incident-suggestions
e34df5b
@vladimir-8
(report an incident): pre-fill manual supplements if not set (to beha…
4acd60b 
…ve as PATCH)
@vladimir-8 vladimir-8 marked this pull request as ready for review December 26, 2025 22:35
@vladimir-8 vladimir-8 mentioned this pull request Dec 26, 2025
Closed
5 tasks
@alexsegura alexsegura merged commit 043f05b into master Dec 29, 2025
8 of 9 checks passed
@alexsegura alexsegura deleted the fix/incident-suggestions branch December 29, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexsegura alexsegura alexsegura approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vladimir-8 @alexsegura