Updated TypeScript typings#235
Merged
Merged
Conversation
Tenga
force-pushed
the
typing-tweaks
branch
from
September 14, 2017 08:13
0b92795 to
8c9d14d
Compare
Owner
|
Nice work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will update the TS typings, as they seem to have gone out of date with the 2.4 config changes.
I've made each property in each config optional, as from what I can tell, most of them have defaults and are not mandatory. It also allows the authors to pass in partial objects (file config with just
attributesinstead of forcing you to definetracks,forceAudio, etc.)Each individual config for each video provider are also now their own exported interfaces so you can reuse the types without having to recreate them yourself in cases like this: