Skip to content

Adding keepPlaying to other player types#1639

Merged
heff merged 7 commits into
cookpete:masterfrom
LoyalPotato:master
Aug 28, 2023
Merged

Adding keepPlaying to other player types#1639
heff merged 7 commits into
cookpete:masterfrom
LoyalPotato:master

Conversation

@LoyalPotato

Copy link
Copy Markdown
Contributor

This is a continuation on the other pull request ( #1620 ) that added this only to YouTube players.

Also changed the default values from the generic player into each specific player, as YouTube for example, has a different default than the rest.

@heff

heff commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

@LoyalPotato, new maintainer here and getting ramped up. Can you help me understand, is this changing any of the existing behavior or keeping it? Does seekTo have different results depending on which player is used?

@LoyalPotato

Copy link
Copy Markdown
Contributor Author

@heff I believe it's more of an addition of behavior. I kept the default values for the new parameter the same as if they weren't there (so most of them are true since it didn't have any option to pause before).
The YouTube player already had this functionality, but it didn't have an option to allow the video to keep playing after using seekTo (#1620). What I've done here is just extend the functionality of that PR into the other players.

@heff

heff commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

Great, makes sense. Thanks!

@heff
heff merged commit 2efb40a into cookpete:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants