Skip to content

Add attributes in FacebookConfig type#1351

Merged
cookpete merged 1 commit into
cookpete:masterfrom
Awkk:master
Feb 19, 2022
Merged

Add attributes in FacebookConfig type#1351
cookpete merged 1 commit into
cookpete:masterfrom
Awkk:master

Conversation

@Awkk

@Awkk Awkk commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

Fix for the below issue when using react-player facebook config in typescript

Current Behavior

  • Using react-player with typescript
  • Typescript flags it as an error if try to pass attributes to FacebookConfig

Expected Behavior

Should be able to configure as below

<ReactPlayer
  url={url}
  config={{
    facebook: {
      attributes: {
        height: "480px"
    }
  }}
/>

@azaareer93

Copy link
Copy Markdown

when will this fix going to be available ?

@cookpete
cookpete merged commit 91a9e0e into cookpete:master Feb 19, 2022
@lukasztucholski

Copy link
Copy Markdown

Bump - can someone fix build?

@cookpete

Copy link
Copy Markdown
Owner

Published in 2.10.0. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants