Fix GitLab changelog URLs for custom domain instances with nested groups #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation assumed any unknown hostname was GitHub-like, which caused incorrect URLs for GitLab instances on custom domains. Problem: For a remote URL like https://git.example.com/foo/bar/baz/project.git, the old code generated: https://git.example.com/foo/bar/commit/... The correct URL should be: https://git.example.com/foo/bar/baz/project/commit/... Root cause: The code used `remote.repo` (only first 2 path segments) in the fallback handler, which broke nested groups in GitLab and any platform supporting deep path hierarchies. Solution: 1. Explicitly detect github.com and use GitHub-specific logic (remote.repo) 2. Detect other known platforms (GitLab, Bitbucket, Azure, etc.) 3. Generic fallback uses remote.pathname for platform-agnostic support This fix: - ✅ Fixes GitLab instances on custom domains with nested groups - ✅ Maintains backward compatibility with all GitHub URLs - ✅ Supports GitHub Enterprise on custom domains - ✅ Works with any git hosting platform using deep path structures - ✅ Preserves HTTP/HTTPS protocol correctly Added comprehensive test coverage for: - GitLab custom domains with nested groups (HTTPS and HTTP) - GitHub Enterprise on custom domains - GitLab instances with "gitlab" in hostname and nested paths
Author
|
Full disclosure: This is entirely LLM-generated and an attempt to fix #299 based on what I think the best solution is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation assumed any unknown hostname was GitHub-like, which caused incorrect URLs for GitLab instances on custom domains.
Problem:
For a remote URL like https://git.example.com/foo/bar/baz/project.git, the old code generated: https://git.example.com/foo/bar/commit/... The correct URL should be: https://git.example.com/foo/bar/baz/project/commit/...
Root cause:
The code used
remote.repo(only first 2 path segments) in the fallback handler, which broke nested groups in GitLab and any platform supporting deep path hierarchies.Solution:
This fix:
Added comprehensive test coverage for: