Skip to content

Conversation

@Ayyanaruto
Copy link
Contributor

@Ayyanaruto Ayyanaruto commented Oct 11, 2025

Description

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Tests

HttpContextProvider.test.ts


Summary by cubic

Fixes HttpContextProvider to safely handle null or missing uri values without throwing. Prevents crashes when servers omit the uri field.

  • Bug Fixes
    • Construct uri with item.uri && { ... } to avoid TypeErrors.
    • Added tests covering valid, missing, null, mixed-array, defaults, and partial uri cases.

@Ayyanaruto Ayyanaruto requested a review from a team as a code owner October 11, 2025 04:56
@Ayyanaruto Ayyanaruto requested review from Patrick-Erichsen and removed request for a team October 11, 2025 04:56
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 11, 2025
@github-actions
Copy link

github-actions bot commented Oct 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Ayyanaruto
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Ayyanaruto
Copy link
Contributor Author

recheck

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the tests!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2025
@Ayyanaruto
Copy link
Contributor Author

I’m really glad that my first PR in Continue got approved thanks for reviewing it! 🎉

@Patrick-Erichsen Patrick-Erichsen merged commit 01c4271 into continuedev:main Oct 13, 2025
83 of 87 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

HTTP provider fails to work in Continue v1.0.19 and later versions

3 participants