-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: HOTFIX prevent active file sending on click #8179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we can remove the usage of Going further, we can also remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="gui/src/components/mainInput/InputToolbar.tsx">
<violation number="1" location="gui/src/components/mainInput/InputToolbar.tsx:226">
When the active-file toggle is off, this should invert both Meta and Alt modifiers; with the new `!meta || alt`, holding Alt always keeps `noContext` true, so you can no longer include the active file with Alt. Please negate the combined condition instead.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
@uinstinct nice find! Pulled and compared vs main, works |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fix the active file sending logic when clicking on the send button.
closes #7941
resolves CON-4195
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
before.mp4
after.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Fixes the send button so clicking it no longer unintentionally includes the active file. Behavior now respects the active file toggle and modifier keys, aligning with CON-4195.