-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Revise build steps in BUILD.md #8130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated build steps to include building local packages before installation.
|
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="extensions/cli/BUILD.md">
<violation number="1" location="extensions/cli/BUILD.md:9">
Running `cd ../../ && node ./scripts/build-packages.js` leaves the user in the repo root, so the subsequent `npm install`/`npm run build` steps execute against the wrong package and the CLI build fails. Wrap the command in a subshell so the working directory stays in `extensions/cli`.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by cubic
Update BUILD.md to run build-packages before npm install and build for the CLI. This prevents missing artifacts and aligns the build with the monorepo script flow.