Skip to content

Conversation

@Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Oct 7, 2025

Summary by cubic

Update BUILD.md to run build-packages before npm install and build for the CLI. This prevents missing artifacts and aligns the build with the monorepo script flow.

Updated build steps to include building local packages before installation.
@Patrick-Erichsen Patrick-Erichsen marked this pull request as ready for review October 7, 2025 21:52
@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner October 7, 2025 21:52
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team October 7, 2025 21:52
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 7, 2025
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="extensions/cli/BUILD.md">

<violation number="1" location="extensions/cli/BUILD.md:9">
Running `cd ../../ &amp;&amp; node ./scripts/build-packages.js` leaves the user in the repo root, so the subsequent `npm install`/`npm run build` steps execute against the wrong package and the CLI build fails. Wrap the command in a subshell so the working directory stays in `extensions/cli`.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@sestinj sestinj merged commit ad8a597 into main Oct 8, 2025
59 of 63 checks passed
@sestinj sestinj deleted the pe/build-md branch October 8, 2025 14:27
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Oct 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 8, 2025

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 12, 2025

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants