Fix too short 6LoWPAN reassembly timeout#766
Merged
nvt merged 1 commit intocontiki-os:masterfrom Nov 7, 2014
Merged
Conversation
Contributor
|
The change in 5c5545b looks like a deliberate attempt to cause fragmentation errors, possibly to test some debug code, and then left there by mistake after testing? This PR should be merged ASAP IMO. |
Contributor
|
Ja, I can't really see why this was introduced, so 👍 . Likely an |
Member
|
👍 |
nvt
pushed a commit
that referenced
this pull request
Nov 7, 2014
Fix too short 6LoWPAN reassembly timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6LoWPAN fragments reassembly timer is started when a first fragmented 6LoWPAN frame is received, all the other fragments must be received before it expires. In Contiki, this timeout is defined in SICSLOWPAN_CONF_MAXAGE and is expressed in seconds.
For unknown reasons, when the timer is started, this timeout value is however divided by 16. WIth the default value of 20, it means the actual timeout is just a bit more than one second. When there are more than a few fragments the reassembly always fails as the timeout is always triggered.
This division by 16 has been introduced in 5c5545b with no really clear reason :) This pull request remove this modification.