forked from chromedp/chromedp
-
Notifications
You must be signed in to change notification settings - Fork 0
add DialOption for adding a header #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jscheithe
wants to merge
4
commits into
master
Choose a base branch
from
dial_headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−3
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import ( | |
| "errors" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "os" | ||
| "os/exec" | ||
| "path/filepath" | ||
|
|
@@ -30,6 +31,8 @@ type Allocator interface { | |
| // Cancelling the allocator context will already perform this operation, | ||
| // so normally there's no need to call Wait directly. | ||
| Wait() | ||
|
|
||
| getDialHeader() http.Header | ||
| } | ||
|
|
||
| // setupExecAllocator is similar to NewExecAllocator, but it allows NewContext | ||
|
|
@@ -327,6 +330,10 @@ func (a *ExecAllocator) Wait() { | |
| a.wg.Wait() | ||
| } | ||
|
|
||
| func (a *ExecAllocator) getDialHeader() http.Header { | ||
| return nil | ||
| } | ||
|
|
||
| // ExecPath returns an ExecAllocatorOption which uses the given path to execute | ||
| // browser processes. The given path can be an absolute path to a binary, or | ||
| // just the name of the program to find via exec.LookPath. | ||
|
|
@@ -552,6 +559,8 @@ type RemoteAllocator struct { | |
| modifyURLFunc func(ctx context.Context, wsURL string) (string, error) | ||
|
|
||
| wg sync.WaitGroup | ||
|
|
||
| dialHeader http.Header | ||
| } | ||
|
|
||
| // Allocate satisfies the Allocator interface. | ||
|
|
@@ -583,6 +592,7 @@ func (a *RemoteAllocator) Allocate(ctx context.Context, opts ...BrowserOption) ( | |
| a.wg.Done() | ||
| }() | ||
|
|
||
| opts = append(opts, WithDialHeaderBrowser(FromContext(ctx).Allocator.getDialHeader())) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see why we need it in the interface |
||
| browser, err := NewBrowser(wctx, wsURL, opts...) | ||
| if err != nil { | ||
| return nil, err | ||
|
|
@@ -605,8 +615,23 @@ func (a *RemoteAllocator) Wait() { | |
| a.wg.Wait() | ||
| } | ||
|
|
||
| func (a *RemoteAllocator) getDialHeader() http.Header { | ||
| return a.dialHeader | ||
| } | ||
|
|
||
| // NoModifyURL is a RemoteAllocatorOption that prevents the remote allocator | ||
| // from modifying the websocket debugger URL passed to it. | ||
| func NoModifyURL(a *RemoteAllocator) { | ||
| a.modifyURLFunc = nil | ||
| } | ||
|
|
||
| func WithDialHeader(h http.Header) RemoteAllocatorOption { | ||
| return func(a *RemoteAllocator) { | ||
| if a.dialHeader == nil { | ||
| a.dialHeader = make(http.Header) | ||
| } | ||
| for k, v := range h { | ||
| a.dialHeader[k] = v | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we need this private method in the Interface? This is usually for external use, internally we should have access to the real implementation ad not through the interface