Semantic border radius tokens [daniel] #3210
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed medium size to fit into an even ramp of multiples of 4 - Changed naming from 'small' to 's', etc. - Added 'l' and 'xl' sizes
Added separate .js file for semantic border radii (placeholder)
added. js suffix to filename
…s-semantic.js to packages/forma-36-tokens/src/tokens/shape-radius-semantic.js
…o packages/forma-36-tokens/src/tokens/radius/sshape-radius-semantic.js
…dius-semantic.js to packages/forma-36-tokens/src/tokens/shape/radius/radius-semantic.js
…packages/forma-36-tokens/src/tokens/shape/radius/scale-radius.js
…js to packages/forma-36-tokens/src/tokens/shape-radius/scale-radius.js
…ic.js to packages/forma-36-tokens/src/tokens/shape-radius/radius-semantic.js
…ic.js to packages/forma-36-tokens/src/tokens/shape/radius/radius-semantic.js
…ic.js to packages/forma-36-tokens/src/tokens/shape-radius/radius-semantic.js
…ackages/forma-36-tokens/src/tokens/shape-spacing/scale-spacing.js
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Marking pull request as stale since there was no activity for 30 days |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR expands the base scale values:
radius-100: 4px (used to b border-radius-small)
radius-200: 8px (used to b border-radius-medium, with 6px)
radius-300: 12px
radius-400: 16px
radius-full: 999px
Additionally it introduces semantic tokens with the goal to create a harmonic combination of border radii. This is a first implementation of new tokens conventions.
The semantic tokens are scoped to component categories – called "element" in the above mentioned conventions. This PR introduces semantic border radii for the elements container (e.g. Card) and control (e.g. Button).
Compositional Logic:
Radius tokens for containers are derived by adding control radius and padding. This ensures visual alignment between inner and outer corners.
Container Radius = Control Radius + Padding
Migration to the new tokens will require a follow up.
PR Checklist
readme.mdfile(s)