Skip to content

Replace HTTPoison with Tesla for flexibility#97

Merged
floriank merged 3 commits into
contentful-userland:mainfrom
OldhamMade:master
Jan 4, 2022
Merged

Replace HTTPoison with Tesla for flexibility#97
floriank merged 3 commits into
contentful-userland:mainfrom
OldhamMade:master

Conversation

@OldhamMade

Copy link
Copy Markdown
Contributor

Changes

  • Replace use of HTTPoison with Tesla
  • Update tests & fixtures to expect httpc as the base HTTP library (the default for Tesla)
  • Bump exvcr version

Resolves #96

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build cb61475a0e6a1c5473f3629c51cf78d57767e082-PR-97

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 80.142%

Totals Coverage Status
Change from base Build 3506210596ec6f2ef7ac531d66519b6ae05dc4a3: 0.7%
Covered Lines: 113
Relevant Lines: 141

💛 - Coveralls

@floriank

floriank commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

sorry for taking so long in reviewing this, I am a bit busy and moving the repo to contentful-userland has apparently changed notification settings.

Will try ASAP :)

@floriank floriank self-requested a review July 1, 2021 10:37
@floriank

floriank commented Jul 9, 2021

Copy link
Copy Markdown
Collaborator

@OldhamMade Could you rebase/merge latest master? 💚

@floriank floriank merged commit a41e817 into contentful-userland:main Jan 4, 2022
@floriank

floriank commented Jan 4, 2022

Copy link
Copy Markdown
Collaborator

Thank you - this completely went under as I've been swamped with projects during work time and never received a notification for the status checks to pass (which seem to have hung themselves after the repo was moved to another organization)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Switch to Tesla for HTTP library

3 participants