feat(helm-chart): support initContainers override#822
Open
wengyao04 wants to merge 2 commits intocontainers:mainfrom
Open
feat(helm-chart): support initContainers override#822wengyao04 wants to merge 2 commits intocontainers:mainfrom
wengyao04 wants to merge 2 commits intocontainers:mainfrom
Conversation
Signed-off-by: yweng14 <[email protected]>
Collaborator
Code reviewFound 1 issue:
kubernetes-mcp-server/charts/kubernetes-mcp-server/values.yaml Lines 169 to 179 in ce0728f Run 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Signed-off-by: yweng14 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(helm): support initContainers in deployment template
This PR adds support for
initContainersin the kubernetes-mcp-server Helm chart.Users can now define fully customizable init containers via
.Values.initContainers, which are rendered usingtplto allowtemplating within container specs.
Highlights:
initContainersin values.yaml (default empty list)This allows workloads to perform pre-start initialization steps (e.g., config generation, secret preparation, data migration)
without forking or patching the chart, and users can use k8s native sidecar containers.