-
Notifications
You must be signed in to change notification settings - Fork 38
Update github.com/cyphar/filepath-securejoin to v0.6.0 and github.com/opencontainers/runc to v1.3.3 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6487 |
|
Looks like you need to bump runc here at the same time, really annoying that the 0.6.0 update introduces breaking changes which means every users must be updates in the right dependency order first. This will be gigantic PITA if the selinux chnage (containers/podman#27466) must be backported. Looking at it closer I doubt we use the selinux code to write labels in untrusted namespaces so maybe we are good without it. |
|
Yes
|
This is necessary to allow the update to github.com/cyphar/filepath-securejoin v0.6.0 . Signed-off-by: Miloslav Trmač <[email protected]>
All of this is making me wonder whether there shouldn’t be some way to solve the overmounts within |
Signed-off-by: Miloslav Trmač <[email protected]>
lsm5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM once tests are green |
|
LGTM |
This is a replacement for #432 , also updating the users of removed functions.
Do note the licensing conversation in #432 — and how #446 needs an updated
filepath-securejoin(does not matter for container-libs, but needed e.g. in containers/podman#27466 ).Cc: @TomSweeneyRedHat . FYI @mheon