pkg/completion: add common completion command #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
force-pushed
the
completion
branch
2 times, most recently
from
d01d693 to
9015a46
Compare
Add the completion command to pkg/completion, this would allow podman, buildah and skopeo to use the same command instead of having to duplicate the logic. The code is mostly copied from podman/cmd/podman/completion. I have modified it a little to make it more generic. Signed-off-by: Paul Holzinger <[email protected]>
Member
|
LGTM |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the completion command to pkg/completion, this would allow podman,
buildah and skopeo to use the same command instead of having to
duplicate the logic.
The code is mostly copied from podman/cmd/podman/completion. I have
modified it a little to make it more generic.