skopeo_cidev: Depend on docker-distribution #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cirrus CI build successful. Found built image names and IDs:
|
lsm5
added a commit
to lsm5/skopeo
that referenced
this pull request
Jul 18, 2025
The skopeo_cidev image is updated with the registry binary from the docker-distribution package instead of building one from source. Ref: containers/automation_images#410 Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
added a commit
to lsm5/skopeo
that referenced
this pull request
Jul 18, 2025
The skopeo_cidev image is updated with the registry binary from the docker-distribution package instead of building one from source. Ref: containers/automation_images#410 Signed-off-by: Lokesh Mandvekar <[email protected]>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
Cirrus CI build successful. Found built image names and IDs:
|
mtrmac
reviewed
Jul 21, 2025
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
For the record, this means that instead of testing interoperability with a specific frozen version, we will be testing interoperability with the latest one — and that package updates can therefore trigger new test failures.
That is probably an improvement — I just want this mentioned.
Having the registry binary named `registry-v2` causes trouble for `make test-integration-local`. The registry binary provided by the docker-distribution package is just `/usr/bin/registry`. Depending on docker-distribution should make things simpler, more consistent and usable regardles of CI / testing environment. In skopeo cirrus jobs, the integration tests are run on the host itself but a lot of the binaries are copied from the skopeo_cidev container. So, in this case docker-distribution is directly installed on the host environment and the registry-v2 build is removed from the skopeo_cidev image. Signed-off-by: Lokesh Mandvekar <[email protected]>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
Cirrus CI build successful. Found built image names and IDs:
|
lsm5
added a commit
to lsm5/skopeo
that referenced
this pull request
Jul 22, 2025
The skopeo_cidev image is updated with the registry binary from the docker-distribution package instead of building one from source. Ref: containers/automation_images#410 Signed-off-by: Lokesh Mandvekar <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Jul 22, 2025
Images from containers/automation_images#410 Signed-off-by: Paul Holzinger <[email protected]>
Member
|
For reference that image contains a "broken" rawhide release due https://bugzilla.redhat.com/show_bug.cgi?id=2382662 I think we only test rawhide on podman so it should not matter that much in general for all the other repos such as skopeo so it is fine to use them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the registry binary named
registry-v2causes trouble formake test-integration-local. The registry binary provided by the docker-distribution package is just/usr/bin/registry.So, depending on docker-distribution should make things simpler, more consistent and usable regardles of CI / testing environment.