Ignore notFound error when collect from pid cgroup #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `pids.current` or `pids.max` not exist in cgroup root (/sys/fs/cgroup/pids/) collect_metrics will print out error level log "...unable to read a control group file /sys/fs/cgroup/pids/./ pids.current..." continually, this commit will ignore these not found errors. As a supplement,if or not set pids.current file in cgroup controller root directory decided by `CFTYPE_NOT_ON_ROOT` flag, in many commen environment it is default to enabled. And as a contrast, go version code will ignore all not found error when collect cgroupv1 metrics: https://github.com/containerd/containerd/blob/b67a788072abd9671804b1ef1a719e3742867d1c/runtime/v2/runc/task/service.go#L625 Co-authored-by: Yukiteru <[email protected]> Signed-off-by: Lei Liu <[email protected]>
zhaodiaoer
force-pushed
the
ignore_notfound_cgroup_metrics
branch
from
2d2bfa9 to
4faf656
Compare
mxpv
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
pids.currentorpids.maxnot exist in cgroup root (/sys/fs/cgroup/pids/) collect_metrics will print out error level log "...unable to read a control group file /sys/fs/cgroup/pids/./ pids.current..." continually, this commit will ignore these not found errors.As a supplement,if or not set pids.current file in cgroup controller root directory decided by
CFTYPE_NOT_ON_ROOTflag, in many commen environment it is default to enabled. And as a contrast, go version code will ignore all not found error when collect cgroupv1 metrics: https://github.com/containerd/containerd/blob/b67a788072abd9671804b1ef1a719e3742867d1c/runtime/v2/runc/task/service.go#L625