Skip to content

Conversation

@bryantbiggs
Copy link
Contributor

Closes #286
Closes #287
Closes #288
Closes #289

Ref: hyperium/hyper#3110

@github-actions github-actions bot added C-client Containerd client T-CI Changes in project's CI labels Aug 2, 2024
@bryantbiggs bryantbiggs force-pushed the chore/update-tonic-prost branch 2 times, most recently from fa24b0a to f42a340 Compare August 2, 2024 19:44
@bryantbiggs bryantbiggs force-pushed the chore/update-tonic-prost branch from ed4c2ee to 5ddcc95 Compare August 3, 2024 02:28
@ckatsak
Copy link
Contributor

ckatsak commented Sep 10, 2024

Hello,

I was wondering what's the status of this PR, as I came across the need for this upgrade.
Is there anything blocking this effort?

Thanks, keep up the great work :)

@bryantbiggs bryantbiggs force-pushed the chore/update-tonic-prost branch from 5ddcc95 to 2035606 Compare September 11, 2024 22:53
@github-actions github-actions bot added C-shim Containerd shim C-runc runc helper labels Sep 11, 2024
@@ -1,3 +1,3 @@
[toolchain]
channel = "1.74"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min version that resolved this error:

error: unsupported output in build script of `containerd-client v0.5.0 (/Users/runner/work/rust-extensions/rust-extensions/crates/client)`: `cargo::rerun-if-changed=vendor/github.com/containerd/containerd/api/types/descriptor.proto`
Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.
warning: build failed, waiting for other jobs to finish...

@bryantbiggs bryantbiggs force-pushed the chore/update-tonic-prost branch 2 times, most recently from bd742f5 to ed79109 Compare September 12, 2024 01:27
@bryantbiggs
Copy link
Contributor Author

@aviramha
Copy link

aviramha commented Oct 4, 2024

@bryantbiggs I think you should use #[allow(unused_imports)] as the intention there is probably to re-export.

@bryantbiggs
Copy link
Contributor Author

ya, let me fire up a windows VM and try fumbling around a bit with this one so maybe we can finally get it across the line 😅

@bryantbiggs bryantbiggs force-pushed the chore/update-tonic-prost branch from ed79109 to 0e5c8cb Compare October 4, 2024 14:26
@github-actions github-actions bot added the C-snapshots Remote snapshotter label Oct 4, 2024
@bryantbiggs
Copy link
Contributor Author

thanks @aviramha for the suggestion, thats what I ended up going with. Once I fired up a Windows VM there were a whole bunch of other clippy errors so just ejected out of that one 😅

@mxpv should be ready for review now

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks!

@mxpv mxpv added this pull request to the merge queue Oct 5, 2024
Merged via the queue into containerd:main with commit 3f541b9 Oct 5, 2024
18 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-tonic-prost branch October 5, 2024 15:10
@aviramha
Copy link

aviramha commented Oct 7, 2024

@mxpv can we have a release for containerd-client please?

@mxpv
Copy link
Member

mxpv commented Oct 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-client Containerd client C-runc runc helper C-shim Containerd shim C-snapshots Remote snapshotter needs update T-CI Changes in project's CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants