Skip to content

Pin libtcmu git tag rather than pointing at the main branch#374

Merged
BigVan merged 1 commit intocontainerd:mainfrom
chewi:pin-tcmu
Aug 13, 2025
Merged

Pin libtcmu git tag rather than pointing at the main branch#374
BigVan merged 1 commit intocontainerd:mainfrom
chewi:pin-tcmu

Conversation

@chewi
Copy link
Contributor

@chewi chewi commented Aug 12, 2025

Having CMake fetch dependencies live is not helpful for distributions, but it should at least not point to a moving target. All the other live dependencies are already pinned.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test? N/A
  • Does this change require a documentation update? N/A
  • Does this introduce breaking changes that would require an announcement or bumping the major version? N/A
  • Do all new files have an appropriate license header? N/A

Having CMake fetch dependencies live is not helpful for distributions,
but it should at least not point to a moving target. All the other live
dependencies are already pinned.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@BigVan
Copy link
Member

BigVan commented Aug 13, 2025

LGTM

@BigVan BigVan merged commit 4601fb2 into containerd:main Aug 13, 2025
2 checks passed
@chewi chewi deleted the pin-tcmu branch December 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants