Skip to content

untar: mv store dirs into extract_file#312

Merged
liulanzheng merged 1 commit intocontainerd:mainfrom
yuchen0cc:main
Jan 26, 2024
Merged

untar: mv store dirs into extract_file#312
liulanzheng merged 1 commit intocontainerd:mainfrom
yuchen0cc:main

Conversation

@yuchen0cc
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Move store dirs into extract_file. (Directory mtimes must be handled at the end to avoid further file creation in them to modify the directory mtime)
This move will avoid aufs whiteout files (.wh..wh.aufs, .wh..wh.orph/, .wh..wh.plnk/) from creating and setting attributes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@yuchen0cc yuchen0cc requested a review from liulanzheng January 26, 2024 06:34
Copy link
Copy Markdown
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit 41bc0db into containerd:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants