support stdin as source for ZFile compression#310
Merged
liulanzheng merged 1 commit intocontainerd:mainfrom Jan 25, 2024
Merged
support stdin as source for ZFile compression#310liulanzheng merged 1 commit intocontainerd:mainfrom
liulanzheng merged 1 commit intocontainerd:mainfrom
Conversation
liulanzheng
reviewed
Jan 25, 2024
| if (ret == 0) { | ||
| break; | ||
| } | ||
| if (ret <= 0) { |
Signed-off-by: Yifan Yuan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, overlaybd-zfile cli only supports local files as a source.
This PR will support STDIN as a source for overlaybd-zfile cli. (eg. cat $file | ./overlaybd-file $out)
Moreover, decompression can't use stdin or pipe as a source since the ZFile index is saved at the end of the file
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: