Skip to content

untar: ignore '/' in tarball#305

Merged
liulanzheng merged 1 commit intocontainerd:mainfrom
yuchen0cc:main
Jan 9, 2024
Merged

untar: ignore '/' in tarball#305
liulanzheng merged 1 commit intocontainerd:mainfrom
yuchen0cc:main

Conversation

@yuchen0cc
Copy link
Contributor

What this PR does / why we need it:
It happens that '/' (root dir) exists in some image tarball layer. It will cause userspace convertor failed.
Now, '/' is ignored.
Add a test case for clean_name().

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com>
Copy link
Contributor

@WaberZhuang WaberZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit 4064710 into containerd:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants