Skip to content

Conversation

@basuotian
Copy link

Feat: dragonflyoss/nydus#1682

The current implement is very rough as some logic should be changed in "github.com/containerd/containerd/v2/core/images/converter". (see unit test testImageReConvertBasic)

Please take a look and see if is necessary to open a pr to containerd.

@imeoer
Copy link
Collaborator

imeoer commented Jun 10, 2025

@basuotian Thanks for the PR! How about moving the containerdreconverter codes into a forked nydus-snapshotter repo? This way we can clearly see the diff of the changes. :)

@basuotian
Copy link
Author

basuotian commented Jun 11, 2025

@basuotian Thanks for the PR! How about moving the containerdreconverter codes into a forked nydus-snapshotter repo? This way we can clearly see the diff of the changes. :)

OK, I did move containerdreconverter into repo github.com/basuotian/nydus-snapshotter-reconverter, and these codes should be part of github.com/containerd/containerd/v2/core/images. @imeoer PTAL

@basuotian
Copy link
Author

@BraveY Thanks for review, fixed follow your recommendations, PTAL

@basuotian basuotian requested a review from BraveY June 19, 2025 07:35
@BraveY
Copy link

BraveY commented Jun 20, 2025

@basuotian Thanks for the PR! Have you modified the code related to the nydusify convert command? Nydusify also needs to support the reconvert feature. Maybe @zephyr could help implement this.

@basuotian
Copy link
Author

@basuotian Thanks for the PR! Have you modified the code related to the nydusify convert command? Nydusify also needs to support the reconvert features. Maybe @zephyr could help implement this.

Yes, i have already finished the code in nydusify, as nydusify depends on nydus-snapshotter so this pr run first

@basuotian basuotian requested a review from BraveY June 25, 2025 02:30
@BraveY
Copy link

BraveY commented Jun 25, 2025

Thanks, Others LGTM! @imeoer cc

@BraveY
Copy link

BraveY commented Sep 15, 2025

@basuotian hi would you fix the broken lint CI? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants