[WIP] converter: only enable tar-rafs conversion by env NYDUS_ENABLE_TAR2RAFS #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recently, we found the tar-rafs conversion lost the opaque file handle: dragonflyoss/nydus#1679 Compare to dir-rafs conversion, the tar-rafs conversion is still a experimental feature, so we'd better disable it by default. And provide an new env `NYDUS_ENABLE_TAR2RAFS` to allow users to enable it. Signed-off-by: Yan Song <[email protected]>
imeoer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recently, we found the tar-rafs conversion lost the opaque file handle: dragonflyoss/nydus#1679
Compare to dir-rafs conversion, the tar-rafs conversion is still a experimental feature, so we'd better disable it by default.
And provide an new env
NYDUS_ENABLE_TAR2RAFSto allow users to enable it.