api,adaptation,generate: allow setting container I/O priority. #155
Conversation
klihub
force-pushed
the
devel/linux-io-priority
branch
11 times, most recently
from
cb1dc14 to
820728f
Compare
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
see question/comment.. on the ability to use ioprio_set() to send the mask 0 meaning class & value is none.. to request kernel 2.6.24+ to unset any previously set priority
|
|
||
| // AdjustIOPriority adjusts the IO priority of the container. | ||
| func (g *Generator) AdjustIOPriority(ioprio *nri.LinuxIOPriority) { | ||
| if ioprio != nil { |
There was a problem hiding this comment.
does this indicate once the optional linux process io priority has been set, it can't be adjusted to unset?
was surprised to see there was no description for setting the IO priority class to default in the oci runtime... excerpt from linux man: If no I/O scheduler has been set for a thread, then by default the I/O priority will follow the CPU nice value ([setpriority(2)](https://www.man7.org/linux/man-pages/man2/setpriority.2.html)). Before Linux 2.6.24, once an I/O priority had been set using ioprio_set(), there was no way to reset the I/O scheduling behavior to the default. Since Linux 2.6.24, specifying ioprio as 0 can be used to reset to the default I/O scheduling behavior.
There was a problem hiding this comment.
@mikebrow Hey, it's almost like you read my mind. This is just what I was addressing in the last force push, but you beat me to it with your review comment. Now setting I/O priority to IOPRIO_CLASS_NONE on the NRI side should cause clearing any set I/O priority in the container's OCI Spec. Although it is not handled here but in SetProcessIOPriority. IOPRIO_CLASS_NONE will cause an empty ("") runtime Spec I/O priority class to be set, which is then interpreted as a marker for clearing any potentially set I/O priority in the Spec.
klihub
force-pushed
the
devel/linux-io-priority
branch
from
820728f to
0baf766
Compare
|
|
||
| case "clear I/O priority": | ||
| a.SetLinuxIOPriority(&nri.LinuxIOPriority{ | ||
| Class: api.IOPrioClass_IOPRIO_CLASS_NONE, |
klihub
force-pushed
the
devel/linux-io-priority
branch
4 times, most recently
from
7f12b29 to
06bf5aa
Compare
|
@mikebrow Should we merge this ? |
Allow setting/resetting container I/O priority. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/linux-io-priority
branch
from
06bf5aa to
3ad35fa
Compare
3 participants
Allow plugins to set container I/O class/priority.
Here is corresponding Process.IOPriority OCI Spec field this PR allows adjusting: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L96
Here is how LinuxIOPriority and other related types are defined in the OCI Spec: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L117
The related NRI types are all straightforward protobuf defined message representations of the corresponding OCI Spec types.