adaptation: return nil as no-op adjustment. #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/use-nil-as-nop-adjustment
branch
from
f765fc8 to
362c075
Compare
klihub
force-pushed
the
devel/use-nil-as-nop-adjustment
branch
from
362c075 to
a39f4c4
Compare
champtar
reviewed
Jan 23, 2025
champtar
approved these changes
Jan 23, 2025
mikebrow
approved these changes
Feb 5, 2025
klihub
force-pushed
the
devel/use-nil-as-nop-adjustment
branch
from
a39f4c4 to
4eab409
Compare
klihub
force-pushed
the
devel/use-nil-as-nop-adjustment
branch
from
4eab409 to
fd82b8b
Compare
Don't create an empty adjustment a priori. Only create once a plugin makes an adjustment to the container being created. In particular, this should result in a nil adjustment if no plugin touches a container. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/use-nil-as-nop-adjustment
branch
from
fd82b8b to
633857b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With no NRI plugins registered or none of the registered plugins requesting changes to a container, we should ideally skip applying NRI adjustments on the runtime side altogether, instead of going through the motions without any effective changes. Having seen #117 (quickly fixed by #116), this is not the case.
This PR is the first part in an attempt to change that. With this PR in place, we don't create an a priori empty adjustment in preparation to process NRI requests. We only create it once a plugin makes an actual change to the container being created. Effectively, this should result in a nil adjustment reply when there are no plugins present, or none of the present plugins touches a container.
The other part is a related change to the runtime integration code to check for this and short-circuit processing.