supervisor: cancel SendTask when channel is full #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
respect-ctx-timeout-sendtask
branch
2 times, most recently
from
2eeb892 to
6346e20
Compare
runcom
force-pushed
the
respect-ctx-timeout-sendtask
branch
6 times, most recently
from
b5cb95b to
8c13151
Compare
This patch handles case c) in moby/moby#31487 (c) A request cannot be added to 's.tasks' because the queue is full. case b) isn't fixable at this point case there's no way to cancel stuff from a channel since channels aren't context aware (yet?). Parallelizing tasks handling isn't easily doable either. Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
respect-ctx-timeout-sendtask
branch
from
8c13151 to
b812857
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch handles case c) in moby/moby#31487
(c) A request cannot be added to 's.tasks' because the queue is full.
case b) isn't fixable at this point case there's no way to cancel stuff
from a channel since channels aren't context aware (yet?).
Parallelizing tasks handling isn't easily doable either.
Signed-off-by: Antonio Murdaca [email protected]
@mlaventure @crosbymichael PTAL