Skip to content

Conversation

@thaJeztah
Copy link
Member

Import the logs module directly, instead of using the aliases that are provided in the logs package. This helps find code-paths that still depend on the old location, and that haven't migrated yet to the new module.

@thaJeztah thaJeztah force-pushed the 1.7_migrate_containerd_log branch from e483bcc to f5eeeeb Compare May 27, 2024 08:53
@thaJeztah thaJeztah self-assigned this May 27, 2024
@thaJeztah
Copy link
Member Author

Looks like I wrote "logs" (plural) in the commit message; let me fix that to prevent confusion.

Import the log module directly, instead of using the aliases that are
provided in the log package. This helps find code-paths that still depend
on the old location, and that haven't migrated yet to the new module.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the 1.7_migrate_containerd_log branch from f5eeeeb to 0af6825 Compare May 27, 2024 12:39
@thaJeztah thaJeztah changed the title [release/1.7] migrate logs imports to github.com/containerd/logs module [release/1.7] migrate log imports to github.com/containerd/log module May 27, 2024
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 300a6de into containerd:release/1.7 May 28, 2024
@thaJeztah thaJeztah deleted the 1.7_migrate_containerd_log branch May 28, 2024 13:31
@dmcgowan dmcgowan changed the title [release/1.7] migrate log imports to github.com/containerd/log module [release/1.7] Migrate log package to github.com/containerd/log Jun 4, 2024
@dmcgowan dmcgowan changed the title [release/1.7] Migrate log package to github.com/containerd/log [release/1.7] Migrate log imports to github.com/containerd/log Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants