-
-
Notifications
You must be signed in to change notification settings - Fork 134
Add WithoutAnsi struct that implements Display #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a36a80 to
5613ddf
Compare
djc
reviewed
Jun 16, 2025
src/without_ansi.rs
Outdated
| use crate::AnsiCodeIterator; | ||
|
|
||
| /// A wrapper struct that implements [`core::fmt::Display`], only displaying non-ansi parts. | ||
| pub struct WithoutAnsi<'a> { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want this in a separate module. Please move it just above the AnsiCodeIterator definition.
5613ddf to
ef4a99f
Compare
djc
approved these changes
Jun 28, 2025
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Sep 9, 2025
Bumps console from 0.15.11 to 0.16.1. Release notes Sourced from console's releases. 0.16.1 What's Changed Add WithoutAnsi struct that implements Display by @ChocolateLoverRaj in console-rs/console#258 Tweak style for new WithAnsi code by @djc in console-rs/console#266 Fix QNX 7.1 patch for libc::cfmakeraw by @rafaeling in console-rs/console#267 Upgrade windows-sys to 0.61 by @djc in console-rs/console#272 0.16.0 What's Changed The 0.15.12 release was yanked after it turned out to be semver-incompatible with existing usage by several of the most popular dependent crates, because it introduced a std feature -- and those crates used default-features = false but relied on the std-guarded features. The 0.16.0 API should be semver-compatible with the 0.15.x API except for the need for the std feature. Prepare 0.16.0 by @djc in console-rs/console#265 Refer to the 0.15.12 release notes for more information. 0.15.12 What's Changed Use EnumSet instead of a full-blown btreemap for the attributes by @jwiesler in console-rs/console#244 Tweak Attributes bit set API by @djc in console-rs/console#245 Implement measure_text_width with no allocation by @remi-dupre in console-rs/console#246 fix(utils): surprising behavior in truncate_str when tail is larger than width by @remi-dupre in console-rs/console#250 fix spelling mistake by @Axlefublr in console-rs/console#253 feat(part): add NO_COLOR env support for windows terminal by @L-Chao in console-rs/console#254 Update windows-sys requirement from 0.59 to 0.60 by @dependabot in console-rs/console#259 Add features to work with no_std, and with alloc in no_std by @ChocolateLoverRaj in console-rs/console#256 Fix CI badge and license URL by @atouchet in console-rs/console#261 Bump version to 0.15.12 by @felstead in console-rs/console#262 Commits f35b2e4 Bump version to 0.16.1 900379f Upgrade windows-sys to 0.61 174b8a4 Bump MSRV to 1.71 (for windows-sys 0.61) 208928e Fix lint warning for elided lifetimes a51fcea Fix QNX patch for libc::cfmakeraw 90ea08d Tweak style for new WithAnsi code 903df6d Add WithoutAnsi struct that implements Display bda6a6e Add FUNDING metadata 87ace80 Remove authors from Cargo metadata (per RFC 3052) 6e30bfd Bump version to 0.16.0 Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Making this a draft PR because #255 should be merged first.