Skip to content

chore: cleanup/refactor activity and rewards contracts.#1214

Merged
raulk merged 16 commits intointegration/rewardsfrom
raulk/rewards-review-contracts
Nov 26, 2024
Merged

chore: cleanup/refactor activity and rewards contracts.#1214
raulk merged 16 commits intointegration/rewardsfrom
raulk/rewards-review-contracts

Conversation

@raulk
Copy link
Copy Markdown
Contributor

@raulk raulk commented Nov 26, 2024

Many cleanups, mostly in atomic commits, so check the changelog.

- merge two libraries into a single one.
- place libraries in lib/ directory.
- adjust error types.
- decouple the rewards logic from the consensus claims logic.
- simplify code; remove indirection; cleanup naming; docs.

TODO:
- rework "distribution" parts.
- reintegrate.
@raulk raulk changed the title wip: cleanup/refactor activity and rewards contracts. chore: cleanup/refactor activity and rewards contracts. Nov 26, 2024
@raulk raulk marked this pull request as ready for review November 26, 2024 15:11
@raulk raulk requested a review from a team as a code owner November 26, 2024 15:11
@raulk raulk merged commit 3ad2c0f into integration/rewards Nov 26, 2024
@raulk raulk deleted the raulk/rewards-review-contracts branch November 26, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant