refactor(ipld): migrate metrics scheme#1207
Merged
LePremierHomme merged 11 commits intomainfrom Nov 28, 2024
Merged
Conversation
karlem
reviewed
Nov 19, 2024
karlem
reviewed
Nov 19, 2024
Contributor
|
Thanks @LePremierHomme! I took a quick look, and overall it looks good. I may have more comments tomorrow. We will also need to add these events to the documentation and ensure that the traces produce user-friendly output. |
Contributor
Author
|
I added domain namespace prefix to the traces, although it's not applied elsewhere. As for the docs, I'll add it as the final step once we're done with the review. |
karlem
reviewed
Nov 20, 2024
karlem
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1093
Current work contains the migration to the event-based architecture.
Still need to evaluate the usefulness of each metric.