Skip to content

fix: add --artifacts-path flag documentation#1199

Merged
raulk merged 1 commit intomainfrom
running_md_fix
Nov 14, 2024
Merged

fix: add --artifacts-path flag documentation#1199
raulk merged 1 commit intomainfrom
running_md_fix

Conversation

@LePremierHomme
Copy link
Copy Markdown
Contributor

Small fix for specifying the --artifacts-path flag needed for seal-genesis command.

Without it, the command fails with the following output:

2024-11-12T08:55:38.110971Z ERROR fendermint/app/src/main.rs:45: failed to execute Options { home_dir: "~/.fendermint", config_dir: None, mode: "dev", global: GlobalArgs { network: Testnet }, command: Genesis(GenesisArgs { genesis_file: "test-network/genesis.json", command: Ipc { command: SealGenesis(SealGenesisArgs { builtin_actors_path: "fendermint/builtin-actors/output/bundle.car", custom_actors_path: "fendermint/actors/output/custom_actors_bundle.car", artifacts_path: None, output_path: "test-network/sealed.car" }) } }) }: ipc enabled but artifacts path not provided

@LePremierHomme LePremierHomme requested a review from a team as a code owner November 12, 2024 09:38
@LePremierHomme LePremierHomme changed the title fix(docs): add --artifacts-path flag documentation fix: add --artifacts-path flag documentation Nov 12, 2024
@karlem
Copy link
Copy Markdown
Contributor

karlem commented Nov 12, 2024

Thanks, it looks good. But I wonder if there are any other places in codebase where it is missing?

@LePremierHomme
Copy link
Copy Markdown
Contributor Author

I don't see other examples where this flag is missing, but I do see it pointing to /fendermint/contracts. I'm not sure if this was the old location, or whether it's being populated on-the-fly during a prior automation. If the former, then all these usages should be broken. Any thoughts?

@raulk raulk merged commit 409c138 into main Nov 14, 2024
@raulk raulk deleted the running_md_fix branch November 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants