Docs: Fix a broken reference for the subnets webpage#1178
Merged
raulk merged 1 commit intoconsensus-shipyard:mainfrom Nov 18, 2024
Merged
Docs: Fix a broken reference for the subnets webpage#1178raulk merged 1 commit intoconsensus-shipyard:mainfrom
raulk merged 1 commit intoconsensus-shipyard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the IPC docs, I realized the subnets link from the main page at https://docs.ipc.space/ is broken.
I suspect the link should redirect to https://docs.ipc.space/concepts/subnets and this is what this MR achieves.
How to test
On the https://docs.ipc.space/ , clicking on the "subnets" link goes to a 404 like page.
On my local fork https://github.com/francoisthire/ipc/tree/main/docs-gitbook we can check the link works as expected.
Note
I have tried to test it locally with gitbook-cli but the tool is deprecated and does not compile anymore with a recent version of node. Maybe there is a way to test it with their online editor at https://www.gitbook.com/ but I did not find how.