Skip to content

feat: prefix metrics with "ipc" #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlem merged 2 commits into from
Oct 15, 2024
+95 −89
Merged

feat: prefix metrics with "ipc" #1172

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536f009
feat: prefix metrics with ipc
karlem Oct 14, 2024
9a04ca1
feat: change docs & tunrn on tracing for tests
karlem Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fendermint/app/src/cmd/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ async fn run(settings: Settings) -> anyhow::Result<()> {

// Prometheus metrics
let metrics_registry = if settings.metrics.enabled {
let registry = prometheus::Registry::new();
let registry = prometheus::Registry::new_custom(Some("ipc".to_string()), None)
.context("failed to create Prometheus registry")?;

register_default_metrics(&registry).context("failed to register default metrics")?;
register_topdown_metrics(&registry).context("failed to register topdown metrics")?;
Expand Down