feat(node): address review comments against #1130#1147
Merged
raulk merged 3 commits intocollateral-sourcingfrom Sep 25, 2024
Merged
feat(node): address review comments against #1130#1147raulk merged 3 commits intocollateral-sourcingfrom
raulk merged 3 commits intocollateral-sourcingfrom
Conversation
6 tasks
cryptoAtwill
approved these changes
Sep 25, 2024
| IGateway(gateway).addStake(amount); | ||
| } | ||
| uint256 msgValue = s.collateralSource.makeAvailable(gateway, amount); | ||
| IGateway(gateway).addStake{value: amount}(amount); |
Contributor
There was a problem hiding this comment.
I think this is not correct, it should be:
IGateway(gateway).addStake{value: msgValue}(amount);
Pushed a PR to this.
Contributor
Author
There was a problem hiding this comment.
Well spotted! Copy pasta
cryptoAtwill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog.