Skip to content

chore(core): fix clippy/fmt + actually use caches#1125

Merged
raulk merged 6 commits intomainfrom
raulk/fix-clippy-fmt
Aug 26, 2024
Merged

chore(core): fix clippy/fmt + actually use caches#1125
raulk merged 6 commits intomainfrom
raulk/fix-clippy-fmt

Conversation

@raulk
Copy link
Copy Markdown
Contributor

@raulk raulk commented Aug 23, 2024

No description provided.

@raulk raulk requested a review from a team as a code owner August 23, 2024 14:48
@raulk raulk changed the title chore(core): fix clippy/fmt. chore(core): fix clippy/fmt + actually use caches Aug 23, 2024
@raulk raulk changed the title chore(core): fix clippy/fmt + actually use caches chore(core): fix clippy/fmt + actually use caches + replace cache Aug 24, 2024
@raulk raulk force-pushed the raulk/fix-clippy-fmt branch from 8a1b729 to 39c207a Compare August 24, 2024 10:23
@raulk raulk changed the title chore(core): fix clippy/fmt + actually use caches + replace cache chore(core): fix clippy/fmt + actually use caches Aug 24, 2024
@raulk
Copy link
Copy Markdown
Contributor Author

raulk commented Aug 24, 2024

Great! Got a full cached build down to 25min, and I think we can do better by:

  1. Building all targets (including tests, benches, etc.) at the top, so we cache their dependencies too.
  2. Running e2e tests with the release profile so it utilises caches.

@raulk raulk merged commit e838384 into main Aug 26, 2024
@raulk raulk deleted the raulk/fix-clippy-fmt branch August 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant