fix(node): remove genesis interpreter#1118
Merged
raulk merged 4 commits intosimple-genesisfrom Aug 21, 2024
Merged
Conversation
raulk
reviewed
Aug 21, 2024
| client: C, | ||
| validator_ctx: Option<ValidatorContext<C>>, | ||
| contracts_dir: PathBuf, | ||
| _contracts_dir: PathBuf, |
Contributor
There was a problem hiding this comment.
Any reason we don't remove this arg?
Contributor
Author
There was a problem hiding this comment.
Good catch, I missed it. Was using it as a placeholder so that not to break so many code at once. Will remove it.
added 2 commits
August 21, 2024 17:05
raulk
approved these changes
Aug 21, 2024
Contributor
raulk
left a comment
raulk
left a comment
There was a problem hiding this comment.
-900 LoC reduction, score! 🎉🎉🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to consistent genesis PR. In that PR, the implementation has been migrate, but some tests are still using the old
GenesisInterpreterand quite coupled/leaked the implementation into unit tests.This PR removes
GenesisInterpretercompletely, update tests and encapsulates all the genesis requirements into new module.