Skip to content

fix: genesis pr CI cleanup#1112

Closed
cryptoAtwill wants to merge 71 commits intosimple-genesisfrom
genesis-pr-cleanup
Closed

fix: genesis pr CI cleanup#1112
cryptoAtwill wants to merge 71 commits intosimple-genesisfrom
genesis-pr-cleanup

Conversation

@cryptoAtwill
Copy link
Copy Markdown
Contributor

@cryptoAtwill cryptoAtwill commented Aug 19, 2024

Some clean up for CI.

A few issues that makes the CI very slow and causing rebuild:

  • ipc_actors_abis built is not deterministic, this is probably from ethers-rust? The same rust binding, if one builds twice, the rust binding generated sometimes is different.
  • Calling makefiles in different folders actually triggers duplicated compilation of solidity abis.

@cryptoAtwill cryptoAtwill requested a review from a team as a code owner August 19, 2024 07:37
@raulk raulk force-pushed the genesis-pr-cleanup branch from e854319 to 4a5841e Compare August 20, 2024 22:38
@raulk raulk force-pushed the genesis-pr-cleanup branch from 0aa40a4 to e72a82d Compare August 21, 2024 18:37
@raulk raulk changed the base branch from simple-genesis to main August 22, 2024 17:33
@raulk raulk changed the base branch from main to simple-genesis August 22, 2024 17:34
@raulk
Copy link
Copy Markdown
Contributor

raulk commented Aug 22, 2024

Superseded by #1124.

@raulk raulk closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants