feat(node): new observability bottom up tracing/metrics#1061
Merged
Conversation
karlem
force-pushed
the
new-observability-bottom-up
branch
2 times, most recently
from
45e4e41 to
85176fe
Compare
karlem
commented
Jul 12, 2024
karlem
changed the title
cryptoAtwill
approved these changes
Jul 15, 2024
karlem
force-pushed
the
new-observability-bottom-up
branch
2 times, most recently
from
5c43582 to
a627c3e
Compare
karlem
changed the title
karlem
changed the title
karlem
force-pushed
the
new-observability-bottom-up
branch
from
a627c3e to
3d5b48d
Compare
raulk
reviewed
Jul 19, 2024
raulk
reviewed
Jul 19, 2024
karlem
force-pushed
the
new-observability-bottom-up
branch
from
e8fe0c2 to
8b938d4
Compare
Contributor
Author
|
Thanks for the review @raulk. I have address all the issues mentioned above. I have also fixed couple of things that we have missed in the previous PR. (eg. removing unused code & registering the metrics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1056