[DO NOT MERGE] Update to CometBFT 0.38#1004
Closed
ec2 wants to merge 7 commits intoconsensus-shipyard:mainfrom
Closed
[DO NOT MERGE] Update to CometBFT 0.38#1004ec2 wants to merge 7 commits intoconsensus-shipyard:mainfrom
ec2 wants to merge 7 commits intoconsensus-shipyard:mainfrom
Conversation
Contributor
Author
|
Passes e2e on my machine locally (Macbook) after #1007 . If someone could enable CI on this PR that would be awesome |
Contributor
|
This is awesome, thank you! The option to allow a CI build is not showing up for me, so I'll need to first figure out what's going on 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests and smoke-tests pass! My local machine (M3 Macbook Pro) is unable to run the e2e tests though.
EDIT: I've been able to pass the e2e test now after applying the fixes from #1007 !!!
DO NOT MERGE, blocked by:
TODO:
[] Remove patches to forked version of
tendermint-rs.Closes: #995, #320
This change is