This repository was archived by the owner on Jan 11, 2024. It is now read-only.
FM-363: Break up smoke-test Makefile.toml into reusable parts#453
Merged
FM-363: Break up smoke-test Makefile.toml into reusable parts#453
Conversation
aakoshh
force-pushed
the
fm-363-reusable-test-toml
branch
from
ebb542c to
407b6db
Compare
dnkolegov
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of consensus-shipyard/ipc#178
This is just a refactoring of the
smoke-test/Makefile.tomlto make common parts of it reusable in other tests.It's similar to how the
infrascripts do it, but also reuses common env vars. The default scenario expects a test task to be defined, so thesetup,test,teardownsequence is executed, with a defaultfendermint,ethapi,cometbftnode setup. The tests that extend this can add further steps, such as starting further containers, at least that's the idea.I'm reusing the
.tomlfragments from theinfrascripts as much as I can.