This repository was archived by the owner on Jan 11, 2024. It is now read-only.
FIX: Do not go to CometBFT during end_block for the power table#426
Merged
FIX: Do not go to CometBFT during end_block for the power table#426
Conversation
aakoshh
force-pushed
the
fix-end-block-power-table
branch
from
8d60c72 to
b592404
Compare
This was referenced Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
end_blockprocessing so that it doesn't try to fetch the power table from CometBFT, which may not respond to requests yet, for example (maybe) because it's trying to replay the last block it failed on.The asynchronous
broadcast_incomplete_signaturesmethod still gets the power table from CometBFT because that's the only place where the history is preserved, but if that fails, at least it will be retried later.