Skip to content

update from dmlc master#2

Merged
congxie1108 merged 2 commits intocongxie1108:masterfrom
dmlc:master
Jun 5, 2019
Merged

update from dmlc master#2
congxie1108 merged 2 commits intocongxie1108:masterfrom
dmlc:master

Conversation

@congxie1108
Copy link
Owner

@congxie1108 congxie1108 commented Jun 5, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin
[refactor] Refactor BERT script folder (#744)
0f5170b 
* move model definition to model/

* update tutorial

* add squad test

* add test argument

* refactor data folder

* fix tutorial

* fix lint

* fix import

* fix import

* update index.rst

* fix tutorial
@eric-haibin-lin
[Enhancement] BERT pre-training data generation from sentencepiece vo…
4f89ca0 
…cab (#743)

* enable fp16 for ln. enable gelu

* manage processes

* manual killl

* support sentencepiece

* dont register signal handler

* add unigram sampling

* support comma for npz format

* fix file race condition

* switch to thread prefetcher

* fix pool.apply

* revert gelu support

* update documentation

* code cleanup

* avoid file download conflcit

* update doc

* fix bug

* bug fix

* more multi-processing

* fix lint

* update doc and fix lint

* fix test argument

* remove -test_bert_sentencepiece_sentences_transform()

* bug fix

* fix lint

* fix doc build
@congxie1108 congxie1108 merged commit fee3aac into congxie1108:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@congxie1108 @eric-haibin-lin