[KIP-932] Fix SGHB mock broker tests to use share consumer API instead of normal consumer#5341
Open
Ankith L (Ankith-Confluent) wants to merge 2 commits intodev_kip-932_queues-for-kafkafrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
dev_kip-932_mock_broker_share_group_heatbeat_test_fix
branch
from
6467fcf to
918d411
Compare
airlock-confluentinc
bot
force-pushed
the
dev_kip-932_mock_broker_share_group_heatbeat_test_fix
branch
from
a1cf944 to
c5a73dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test 0155 to use share consumer public API (
rd_kafka_share_consumer_new,rd_kafka_share_subscribe,rd_kafka_share_consumer_close,test_share_consume_msgs) instead of normal consumer functions with internal config hacks. Assignment and fatal error checks temporarily usetest_share_consumer_get_rkuntil share wrappers are available.