Add more tests to sharefetch#5321
Merged
Ankith L (Ankith-Confluent) merged 2 commits intodev_kip-932_queues-for-kafkafrom Feb 20, 2026
Merged
Add more tests to sharefetch#5321Ankith L (Ankith-Confluent) merged 2 commits intodev_kip-932_queues-for-kafkafrom
Ankith L (Ankith-Confluent) merged 2 commits intodev_kip-932_queues-for-kafkafrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Kaushik Raina (k-raina)
approved these changes
Feb 20, 2026
Member
Kaushik Raina (k-raina)
left a comment
Kaushik Raina (k-raina)
left a comment
There was a problem hiding this comment.
Thanks. LGTM!
| * Injects 1 error of type \p err into the ShareFetch path, | ||
| * then verifies the consumer returns no records on that fetch. | ||
| * | ||
| * Java: testFetchError, testHandleFetchResponseError |
There was a problem hiding this comment.
Can we remove this?
Member
Author
There was a problem hiding this comment.
Sure, I have removed it.
Ankith L (Ankith-Confluent)
merged commit 27e2aba
into
dev_kip-932_queues-for-kafka
1 of 2 checks passed
airlock-confluentinc Bot
pushed a commit
that referenced
this pull request
Mar 2, 2026
* Add tests for ShareFetch error handling and implicit close * Remove Java references from ShareFetch error handling test descriptions
airlock-confluentinc Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
* Add tests for ShareFetch error handling and implicit close * Remove Java references from ShareFetch error handling test descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and implicit close behavior