Upgrade clang-format patch version from v18.1.3 to v18.1.8 as developer's changes fail on CI#5317
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker-based CI infrastructure to use a newer version of clang-format 18 from the official LLVM repository. The changes address issues where developer's code formatting changes were failing in CI, likely due to version inconsistencies between the Ubuntu default package and what developers were using locally.
Changes:
- Added LLVM apt repository to the Dockerfile to get a more recent clang-format 18 version
- Added version debugging output to style checking scripts
- Incremented the CI cache tag to force rebuilding Docker images with the new configuration
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packaging/tools/Dockerfile | Adds LLVM repository configuration and installs clang-format-18 from it, with version verification |
| packaging/tools/style-format.sh | Adds debug output to print clang-format version before validation |
| packaging/tools/run-style-check.sh | Adds debug output to print clang-format version |
| .semaphore/semaphore.yml | Increments cache tag from 7 to 8 to invalidate cached Docker images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er's changes fail on CI
ef54dc6 to
01a1be5
Compare
Pratyush Ranjan (PratRanj07)
left a comment
There was a problem hiding this comment.
LGTM
No description provided.