Skip to content

Upgrade clang-format patch version from v18.1.3 to v18.1.8 as developer's changes fail on CI#5317

Open
Pranav Rathi (pranavrth) wants to merge 1 commit intomasterfrom
dev_upgrade-ci-clang-format-to-18.1.8-from-18.1.3
Open

Upgrade clang-format patch version from v18.1.3 to v18.1.8 as developer's changes fail on CI#5317
Pranav Rathi (pranavrth) wants to merge 1 commit intomasterfrom
dev_upgrade-ci-clang-format-to-18.1.8-from-18.1.3

Conversation

@pranavrth
Copy link
Member

No description provided.

@pranavrth Pranav Rathi (pranavrth) requested a review from a team as a code owner February 16, 2026 22:11
Copilot AI review requested due to automatic review settings February 16, 2026 22:11
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker-based CI infrastructure to use a newer version of clang-format 18 from the official LLVM repository. The changes address issues where developer's code formatting changes were failing in CI, likely due to version inconsistencies between the Ubuntu default package and what developers were using locally.

Changes:

  • Added LLVM apt repository to the Dockerfile to get a more recent clang-format 18 version
  • Added version debugging output to style checking scripts
  • Incremented the CI cache tag to force rebuilding Docker images with the new configuration

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

File Description
packaging/tools/Dockerfile Adds LLVM repository configuration and installs clang-format-18 from it, with version verification
packaging/tools/style-format.sh Adds debug output to print clang-format version before validation
packaging/tools/run-style-check.sh Adds debug output to print clang-format version
.semaphore/semaphore.yml Increments cache tag from 7 to 8 to invalidate cached Docker images

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_upgrade-ci-clang-format-to-18.1.8-from-18.1.3 branch from ef54dc6 to 01a1be5 Compare February 21, 2026 22:31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants