Skip to content

Improve linger/timeout validation error message with aliases #5314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MXLange wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

Improve linger/timeout validation error message with aliases #5314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/rdkafka_conf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4429,8 +4429,13 @@ const char *rd_kafka_conf_finalize(rd_kafka_type_t cltype,
conf->buffering_max_ms_dbl) {
if (rd_kafka_conf_is_modified(conf,
"linger.ms"))
return "`message.timeout.ms` must be "
"greater than `linger.ms`";
return "`delivery.timeout.ms` "
"(alias "
"`message.timeout.ms`) "
"must be greater than "
"`linger.ms` "
"(alias "
"`queue.buffering.max.ms`)";
Comment on lines +4432 to +4438
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alias relationships in this error message are backwards. According to the configuration definitions:

  • message.timeout.ms (line 1730) is the primary/canonical property, and delivery.timeout.ms (line 1742) is an alias for it
  • queue.buffering.max.ms (line 1579) is the primary/canonical property, and linger.ms (line 1588) is an alias for it

The error message should say:

  • message.timeout.ms (alias delivery.timeout.ms) must be greater than queue.buffering.max.ms (alias linger.ms)

This would correctly show the canonical property first, followed by its alias in parentheses.

Suggested change
return "`delivery.timeout.ms` "
"(alias "
"`message.timeout.ms`) "
"must be greater than "
"`linger.ms` "
"(alias "
"`queue.buffering.max.ms`)";
return "`message.timeout.ms` "
"(alias "
"`delivery.timeout.ms`) "
"must be greater than "
"`queue.buffering.max.ms` "
"(alias "
"`linger.ms`)";

Copilot uses AI. Check for mistakes.
else /* Auto adjust linger.ms to be lower
* than message.timeout.ms */
conf->buffering_max_ms_dbl =
Expand Down Expand Up @@ -4506,7 +4511,9 @@ const char *rd_kafka_topic_conf_finalize(rd_kafka_type_t cltype,
if (tconf->message_timeout_ms != 0 &&
(double)tconf->message_timeout_ms <= conf->buffering_max_ms_dbl &&
rd_kafka_conf_is_modified(conf, "linger.ms"))
return "`message.timeout.ms` must be greater than `linger.ms`";
return "`delivery.timeout.ms` "
"(alias `message.timeout.ms`) must be greater than "
"`linger.ms` (alias `queue.buffering.max.ms`)";
Comment on lines +4514 to +4516
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alias relationships in this error message are backwards. According to the configuration definitions:

  • message.timeout.ms (line 1730) is the primary/canonical property, and delivery.timeout.ms (line 1742) is an alias for it
  • queue.buffering.max.ms (line 1579) is the primary/canonical property, and linger.ms (line 1588) is an alias for it

The error message should say:

  • message.timeout.ms (alias delivery.timeout.ms) must be greater than queue.buffering.max.ms (alias linger.ms)

This would correctly show the canonical property first, followed by its alias in parentheses.

Suggested change
return "`delivery.timeout.ms` "
"(alias `message.timeout.ms`) must be greater than "
"`linger.ms` (alias `queue.buffering.max.ms`)";
return "`message.timeout.ms` "
"(alias `delivery.timeout.ms`) must be greater than "
"`queue.buffering.max.ms` (alias `linger.ms`)";

Copilot uses AI. Check for mistakes.

return NULL;
}
Expand Down
Loading