src/rdkafka_conf.c: fix curl/curl.h include when WITH_CURL=OFF#5309
Open
Thomas Devoogdt (ThomasDevoogdt) wants to merge 1 commit intoconfluentinc:masterfrom
Open
src/rdkafka_conf.c: fix curl/curl.h include when WITH_CURL=OFF#5309Thomas Devoogdt (ThomasDevoogdt) wants to merge 1 commit intoconfluentinc:masterfrom
Thomas Devoogdt (ThomasDevoogdt) wants to merge 1 commit intoconfluentinc:masterfrom
Conversation
Thomas Devoogdt (ThomasDevoogdt)
requested a review
from a team
as a code owner
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Change #ifdef to #if for WITH_OAUTHBEARER_OIDC preprocessor check. When using CMake's cmakedefine01, the macro is always defined (as 0 or 1), so #ifdef always evaluates to true. Using #if correctly checks the value. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Thomas Devoogdt (ThomasDevoogdt)
force-pushed
the
bugfix/curl
branch
from
5061a5b to
b39b005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change #ifdef to #if for WITH_OAUTHBEARER_OIDC preprocessor check. When using CMake's cmakedefine01, the macro is always defined (as 0 or 1), so #ifdef always evaluates to true. Using #if correctly checks the value.
Fixes: #5204